fix: use docstore.index for get_metadata_values_by_key (OpenSearch / elasticsearch) #7562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
All docstore methods normally take
self.index
as index param of opensearch / elasticsearch requests if no value forindex
has been passed explicitly.get_metadata_values_by_key
misses this behavior.Proposed Changes:
get_metadata_values_by_key
usesself.index
ifindex=None
batch_size
param added toget_metadata_values_by_key
to controll efficient pagingHow did you test it?
batch_size
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.