Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just some more quick fixes #7498

Merged
merged 2 commits into from
Apr 8, 2024
Merged

just some more quick fixes #7498

merged 2 commits into from
Apr 8, 2024

Conversation

davidsbatista
Copy link
Contributor

Related Issues

  • some docstring quick fixes

@davidsbatista davidsbatista requested a review from a team as a code owner April 8, 2024 08:30
@davidsbatista davidsbatista requested review from shadeMe and removed request for a team April 8, 2024 08:30
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 8, 2024
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 8, 2024
haystack/utils/url_validation.py Outdated Show resolved Hide resolved
@davidsbatista davidsbatista enabled auto-merge (squash) April 8, 2024 08:41
@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8597139913

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 89.663%

Files with Coverage Reduction New Missed Lines %
utils/callable_serialization.py 3 85.71%
utils/hf.py 22 78.87%
Totals Coverage Status
Change from base Build 8596876748: 0.0%
Covered Lines: 5881
Relevant Lines: 6559

💛 - Coveralls

@davidsbatista davidsbatista merged commit 3777f43 into main Apr 8, 2024
20 checks passed
@davidsbatista davidsbatista deleted the fixing-docstrings branch April 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants