-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docs of MetaFieldRanker, TransformersSimilarityRanker #7301
Conversation
Pull Request Test Coverage Report for Build 8153447014Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some minor comments. (Feel free to consider or discard them.)
I appreciated your efforts to better explain what is going on in the Components.
-'float' will parse the meta values into floats. | ||
-'int' will parse the meta values into integers. | ||
-'date' will parse the meta values into datetime objects. | ||
-'None' (default) will do no parsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I had no luck with rendering bulleted lists inside params. I always got a flat list.
Please check locally if the generated markdown is ok.
Co-authored-by: Stefano Fiorucci <[email protected]>
Related Issues
haystack.components.rankers
#7112Proposed Changes:
component_to_dict(obj)
.How did you test it?
Notes for the reviewer
LostInTheMiddleRanker was done in a separate PR: #7294
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.