Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add raise_on_failure to BaseConverter #6930

Merged
merged 11 commits into from
Feb 7, 2024
Merged

feat: Add raise_on_failure to BaseConverter #6930

merged 11 commits into from
Feb 7, 2024

Conversation

isaac-chung
Copy link

@isaac-chung isaac-chung commented Feb 7, 2024 •
edited
Loading

Related Issues

Proposed Changes:

Followed the potential solution (Thanks @anakin87 !) to add a raise_on_failure to the run method in the BaseConverter class.

How did you test it?

Added unit tests with the CSV converter.

Notes for the reviewer

Checklist

@isaac-chung isaac-chung requested review from a team as code owners February 7, 2024 07:01
@isaac-chung isaac-chung requested review from dfokina and davidsbatista and removed request for a team February 7, 2024 07:01
@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@isaac-chung
Copy link
Author

Whoops I probably need to rebase my branch. I checked out v1.x since I don't see the nodes folder in the main branch.

@anakin87
Copy link
Member

anakin87 commented Feb 7, 2024 •
edited
Loading

Hello... thanks for the contribution!
Should be rebased on the v1.x branch.

I did it and fixed some stuff...

@anakin87 anakin87 changed the base branch from main to v1.x February 7, 2024 07:57
@anakin87 anakin87 requested review from anakin87 and removed request for davidsbatista February 7, 2024 07:59
anakin87
anakin87 reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good!

I left a comment with an opportunity for improvement...

haystack/nodes/file_converter/base.py Show resolved Hide resolved
@isaac-chung isaac-chung requested a review from anakin87 February 7, 2024 08:18
anakin87
anakin87 reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for quickly addressing my comments!

some final touches and then this PR is ready to go.

haystack/nodes/file_converter/base.py Outdated Show resolved Hide resolved
test/nodes/test_file_converter.py Outdated Show resolved Hide resolved
isaac-chung and others added 2 commits February 7, 2024 10:28
@isaac-chung @anakin87
Update wording
25be868 
Co-authored-by: Stefano Fiorucci <[email protected]>
@isaac-chung @anakin87
Copy paste whoops
2a9c67c 
Co-authored-by: Stefano Fiorucci <[email protected]>
@isaac-chung isaac-chung requested a review from anakin87 February 7, 2024 08:32
@isaac-chung
Copy link
Author

isaac-chung commented Feb 7, 2024 •
edited
Loading

Thanks for the quick feedback :)

anakin87
anakin87 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@anakin87 anakin87 merged commit 56b8b0d into deepset-ai:v1.x Feb 7, 2024
53 checks passed
@anakin87 anakin87 mentioned this pull request Feb 7, 2024
Closed
@isaac-chung isaac-chung deleted the raise_on_failure-base-converter branch February 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:file_converter topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseConverter more robust and reliable when processing thousands of files.
3 participants
@isaac-chung @CLAassistant @anakin87