refactor: Rename docstore fixture to document_store
#6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
the
ignore-for-release-notes
github-actions
bot
added
topic:tests
2.x
|
There's something funky going on with the tests, don't merge this for now. |
silvanocerza
force-pushed
the
rename-fixture
branch
from
fca4728 to
ca77310
Compare
|
Rebased on top of #6361, tests are fine now. |
|
This PR changes only tests in Preview tests were successful in any case. https://github.com/deepset-ai/haystack/actions/runs/6931402548?pr=6360 |
anakin87
approved these changes
Nov 20, 2023
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Prevent pytest_generate_tests from polluting preview tests * Rename docstore fixture to document_store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #6284
Proposed Changes:
Rename
doctstorefixture used by Document Store tests todocument_storefor consistency.How did you test it?
I ran tests locally and updated the ones using the fixture.
Notes for the reviewer
This is part of a series of PRs, I'll update release notes at the end.
Depends on #6361.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.