Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: InMemoryDocumentStore - recreate Documents in the right way during embedding retrieval #6354

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix: InMemoryDocumentStore - recreate Documents in the right way during embedding retrieval #6354

merged 4 commits into from
Nov 20, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 20, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • The issue was related to recent refactorings of the Document class.
  • To recreate the document from a dictionary, I correctly use from_dict

How did you test it?

Checklist

@anakin87 anakin87 requested a review from a team as a code owner November 20, 2023 10:05
@anakin87 anakin87 requested review from silvanocerza and removed request for a team November 20, 2023 10:05
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Nov 20, 2023
@anakin87 anakin87 changed the title refactor: make InMemoryDocumentStore not recreate docs refactor: make InMemoryDocumentStore not recreate docs during retrieval Nov 20, 2023
@anakin87 anakin87 marked this pull request as draft November 20, 2023 10:07
@anakin87 anakin87 changed the title refactor: make InMemoryDocumentStore not recreate docs during retrieval fix: InMemoryDocumentStore - recreate Documents in the right way during embedding retrieval Nov 20, 2023
@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 20, 2023
@anakin87 anakin87 marked this pull request as ready for review November 20, 2023 10:36
@anakin87 anakin87 merged commit 0ef06e7 into main Nov 20, 2023
32 of 33 checks passed
@anakin87 anakin87 deleted the inmemory-do-not-recreate-docs branch November 20, 2023 11:10
vblagoje pushed a commit that referenced this pull request Nov 22, 2023
@anakin87 @vblagoje
fix: InMemoryDocumentStore - recreate Documents in the right way duri…
0364957 
…ng embedding retrieval (#6354)

* do not recreate docs

* copy Documents

* recreate Document in the right way

* improve naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documents with metadata raises an error in InMemoryDocumentStore
2 participants
@anakin87 @silvanocerza