Extends input types of RemoteWhisperTranscriber
#6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
requested review from
masci and
vblagoje
and removed request for
a team and
masci
|
@ZanSara do we need any additional unit tests? |
|
Oh I thought I pushed it! I'll take care of it asap |
…haystack into remotetranscriber-input-type
vblagoje
requested changes
Nov 8, 2023
vblagoje
reviewed
Nov 10, 2023
|
Hey @ZanSara there seem to be some test failures on this one. Let's clean these up and integrate. Also note more comment I left. Perhaps a different PR and then find all references to this file_path fixing and remove them |
vblagoje
pushed a commit
that referenced
this pull request
Nov 22, 2023
* fix tests * reno * tests * retain file name * paths are strings for openai sdk * streams->sources * feedback * always add name to file * mypy * test placeholder with extension * fallback * paths * path test * path must be a string * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
FileTypeRoutertoRemoteWhisperTranscriber#6216Proposed Changes:
Extends input types of
RemoteWhisperTranscriberfromList[ByteStream]toList[Union[str, Path, ByteStream]]to make possible to connect it toFileTypeRouter(see issue)How did you test it?
Local tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.