Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add mime_type field to ByteStream #6154

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feature: Add mime_type field to ByteStream #6154

merged 3 commits into from
Oct 23, 2023

Conversation

silvanocerza
Copy link
Contributor

Proposed Changes:

Add mime_type field to ByteStream dataclass.

How did you test it?

Ran unit tests locally.

Notes for the reviewer

We're going to remove mime_type in Document and change blob to ByteStream after this.

Checklist

@silvanocerza silvanocerza added the 2.x Related to Haystack v2.0 label Oct 23, 2023
@silvanocerza silvanocerza self-assigned this Oct 23, 2023
@silvanocerza silvanocerza requested a review from a team as a code owner October 23, 2023 12:44
@silvanocerza silvanocerza requested review from julian-risch and removed request for a team October 23, 2023 12:44
@silvanocerza silvanocerza requested a review from a team as a code owner October 23, 2023 12:47
@silvanocerza silvanocerza requested review from dfokina and removed request for a team October 23, 2023 12:47
julian-risch
julian-risch requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_from_file_path and test_from_string in test/preview/dataclasses/test_byte_stream.py should be updated to account for the newly added mime_type parameter. Otherwise looks good to me. 👍

julian-risch
julian-risch approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@silvanocerza silvanocerza merged commit 31fb5b8 into main Oct 23, 2023
21 checks passed
@silvanocerza silvanocerza deleted the byte-stream-mime-type branch October 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees

@silvanocerza silvanocerza

Labels
2.x Related to Haystack v2.0 topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvanocerza @julian-risch