Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add apple silicon GPU acceleration #6151

Merged
merged 24 commits into from
Oct 30, 2023
Merged

feat: add apple silicon GPU acceleration #6151

merged 24 commits into from
Oct 30, 2023

Conversation

NripeshN
Copy link
Contributor

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@NripeshN NripeshN requested a review from a team as a code owner October 23, 2023 04:52
@NripeshN NripeshN requested review from masci and removed request for a team October 23, 2023 04:52
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Can you add a release note for this feature? See https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes

@NripeshN NripeshN requested a review from a team as a code owner October 23, 2023 13:04
@NripeshN NripeshN requested review from dfokina and masci and removed request for a team October 23, 2023 13:04
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2023

Pull Request Test Coverage Report for Build 6664918061

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 59 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 50.836%

Files with Coverage Reduction New Missed Lines %
environment.py 1 90.38%
utils/context_matching.py 1 95.7%
utils/torch_utils.py 2 40.0%
utils/experiment_tracking.py 6 43.54%
preview/components/readers/extractive.py 7 93.88%
modeling/utils.py 42 27.53%
Totals Coverage Status
Change from base Build 6656519629: -0.01%
Covered Lines: 12983
Relevant Lines: 25539

💛 - Coveralls

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging as soon as the CI goes 💚

haystack/environment.py Outdated Show resolved Hide resolved
@NripeshN NripeshN requested a review from masci October 24, 2023 02:52
@github-actions github-actions bot added the type:documentation Improvements on the docs label Oct 25, 2023
@masci
Copy link
Contributor

masci commented Oct 25, 2023

@NripeshN there's a test failing because mps is out of memory: https://github.com/deepset-ai/haystack/actions/runs/6642866434/job/18049052738?pr=6151 Good news this patch seems to work, but I think we need to disable mps in the CI? Any idea how to do that?

@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Oct 26, 2023
This reverts commit 783ae50.
@github-actions github-actions bot removed the topic:CI label Oct 26, 2023
@NripeshN NripeshN requested a review from masci October 26, 2023 10:43
@masci
Copy link
Contributor

masci commented Oct 26, 2023

The failing test is about pylint not playing well with LazyImport - This is unrelated so I'm going to merge this one and will figure out the problem later.

@masci
Copy link
Contributor

masci commented Oct 27, 2023

Uhm we keep hitting out of memory errors in the CI workers... Any chance we can force-disable mps on CI?

@NripeshN NripeshN requested a review from masci October 29, 2023 18:01
@masci masci merged commit 708d33a into deepset-ai:main Oct 30, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 topic:CI topic:modeling type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple silicon GPU support("mps")
4 participants