-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add apple silicon GPU acceleration #6151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Can you add a release note for this feature? See https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes
Pull Request Test Coverage Report for Build 6664918061
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Merging as soon as the CI goes 💚
@NripeshN there's a test failing because mps is out of memory: https://github.com/deepset-ai/haystack/actions/runs/6642866434/job/18049052738?pr=6151 Good news this patch seems to work, but I think we need to disable mps in the CI? Any idea how to do that? |
This reverts commit 783ae50.
The failing test is about |
Uhm we keep hitting out of memory errors in the CI workers... Any chance we can force-disable mps on CI? |
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.