Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated RemoteWhisperTranscriber from whisper-openai to openai sdk #6142

Closed
wants to merge 1 commit into from

Conversation

Mohit1345
Copy link

Related Issues

Proposed Changes:

Adding open ai sdk snipper into _raw_transcriber function defined in RemoteWhisperClass and making other required small changes.

How did you test it?

Notes for the reviewer

Checklist

@Mohit1345 Mohit1345 requested a review from a team as a code owner October 21, 2023 07:43
@Mohit1345 Mohit1345 requested review from anakin87 and removed request for a team October 21, 2023 07:43
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type:documentation Improvements on the docs label Oct 21, 2023
@anakin87
Copy link
Member

Hello, @Mohit1345. Thanks for your contribution...

I noticed that another pull request with the same purpose has been opened (#6149).
I suggest that you collaborate on it, as it also fixes a portion of another issue (#6116).

@Mohit1345
Copy link
Author

Hello, @Mohit1345. Thanks for your contribution...

I noticed that another pull request with the same purpose has been opened (#6149). I suggest that you collaborate on it, as it also fixes a portion of another issue (#6116).

ok sure!

@awinml
Copy link
Contributor

awinml commented Oct 26, 2023

@Mohit1345 Thank you for your help!

I think we can close this PR now, since PR #6149 just got merged and the issue #5731 has been closed.

CC: @anakin87

@vblagoje
Copy link
Member

@Mohit1345 first of all, thank you for this contribution. Please keep an eye on good first issue Good for newcomers Looking forward to your next contribution.

@vblagoje
Copy link
Member

Closing as #6149 already implemented this feature

@vblagoje vblagoje closed this Oct 27, 2023
@bilgeyucel
Copy link
Contributor

Hi @Mohit1345, thank you for opening this PR! Even though it wasn't merged, we'd love to send you some cool Haystack swag as a way of saying thanks for your effort and time. 🎁

Fill in this form, and let us know if you have any questions! https://forms.gle/226vqWoN6NRAaqJ69

@Mohit1345
Copy link
Author

Mohit1345 commented Oct 31, 2023

Hi @Mohit1345, thank you for opening this PR! Even though it wasn't merged, we'd love to send you some cool Haystack swag as a way of saying thanks for your effort and time. 🎁

Fill in this form, and let us know if you have any questions! https://forms.gle/226vqWoN6NRAaqJ69

Thank you @bilgeyucel for swags , looking forward to contribute and use haystack for ai applications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Whisper transcriber (v2.0) to OpenAI SDK
6 participants