refactor: Change Document.embedding type to list of floats
#6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
requested review from
dfokina and
masci
and removed request for
a team
github-actions
bot
added
topic:tests
type:documentation
silvanocerza
force-pushed
the
remove-id-hash-document
branch
from
67459a2 to
96055c2
Compare
silvanocerza
force-pushed
the
document-embedding-type
branch
3 times, most recently
from
8851c2c to
43a0502
Compare
silvanocerza
force-pushed
the
remove-id-hash-document
branch
from
c8ac5c6 to
11c916a
Compare
silvanocerza
force-pushed
the
document-embedding-type
branch
from
43a0502 to
12bccc0
Compare
silvanocerza
force-pushed
the
remove-id-hash-document
branch
from
11c916a to
5180526
Compare
silvanocerza
force-pushed
the
document-embedding-type
branch
from
12bccc0 to
3194cfb
Compare
silvanocerza
force-pushed
the
document-embedding-type
branch
from
3194cfb to
8350f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Document.embeddinga list of float #6132Proposed Changes:
This PR changes the
Document.embeddingfromnumpy.ndarraytoList[float]to ease usage of embeddings.It also changes all usages and tests that were setting embedding as an
ndarray. Some tests were already using it as aList[float]so they weren't changed.How did you test it?
Ran unit tests locally.
Notes for the reviewer
Depends on #6127.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.