feat: Add DocumentCleaner 2.0 #5976
Merged
+434
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
changed the title
julian-risch
requested review from
dfokina and
anakin87
and removed request for
a team
anakin87
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Hey, @julian-risch... Good work!
I found some opportunities for improvement
(and several occasions for me to better understand).
haystack/preview/components/preprocessors/text_document_cleaner.py
Outdated
Show resolved
Hide resolved
haystack/preview/components/preprocessors/text_document_cleaner.py
Outdated
Show resolved
Hide resolved
haystack/preview/components/preprocessors/text_document_cleaner.py
Outdated
Show resolved
Hide resolved
julian-risch
changed the title
anakin87
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
TextDocumentCleaner#5676Proposed Changes:
Add new DocumentCleaner component with the options to
Also added new unit tests for this component.
The code for removing repeated substrings (footers, headers) was mostly copied over from 1.x.
How did you test it?
Added new unit tests. We should add an end-to-end test later with an indexing pipeline containing a file converter, text document cleaner and text document splitter components. The end-to-end test will be added in the PR with the last component needed here: https://github.com/deepset-ai/haystack/pull/6037/files#diff-963c94f5742eb94f8771a87759aa17307f9cc868fa6ecbe80a431b4dcf14cf28
Notes for the reviewer
The issues mentions to update "structure dictionary properly if it’s present" but I didn't address it so far in this PR. Not 100% clear to me what this should look like and probably not needed for 2.0. Could be added later.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.