Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unfreeze Document in Haystack 2.0 #5974

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: Unfreeze Document in Haystack 2.0 #5974

merged 2 commits into from
Oct 5, 2023

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Oct 5, 2023

As a part of the ongoing improvements for #5945 let's unfreeze Document as it is blocking for #5923

@vblagoje vblagoje requested a review from a team as a code owner October 5, 2023 09:45
@vblagoje vblagoje requested review from anakin87 and removed request for a team October 5, 2023 09:45
@vblagoje vblagoje added ignore-for-release-notes PRs with this flag won't be included in the release notes. 2.x Related to Haystack v2.0 labels Oct 5, 2023
@vblagoje vblagoje changed the title feat: Unfreeze document in Haystack 2.0 feat: Unfreeze Document in Haystack 2.0 Oct 5, 2023
@anakin87
Copy link
Member

anakin87 commented Oct 5, 2023

The implementation itself is ok.

I'm just thinking about the consequences of unfreezing this class.
Some thoughts expressed by @ZanSara:

@vblagoje
Copy link
Member Author

vblagoje commented Oct 5, 2023

I say we unfreeze and then follow the recommendations @ZanSara outlined in #5899 @masci you were confident about unfreezing this morning, but we didn't elaborate. Are we ok to unfreeze?

@masci
Copy link
Contributor

masci commented Oct 5, 2023

I don't get why the ID should be kept in sync with the content, or even the embeddings of a Document. If users provide an ID themselves, that's not on Haystack to decide if the ID is valid or not; if users don't provide an ID, Haystack will generate one for them trying to minimize conflicts, but that's it. All the major vector databases allow to update embeddings for the same ID, why Haystack shouldn't?
@vblagoje curious why you suggest we should follow the recommendations in #5899?

@vblagoje
Copy link
Member Author

vblagoje commented Oct 5, 2023

@masci mostly because I didn't participate in that conversation so I suggested it as a middle ground 😀

@vblagoje vblagoje merged commit 282419d into main Oct 5, 2023
@vblagoje vblagoje deleted the unfreeze_doc branch October 5, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants