Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change meta schema #4321

Closed
wants to merge 0 commits into from
Closed

refactor: Change meta schema #4321

wants to merge 0 commits into from

Conversation

manulpatel
Copy link

Related Issues

Proposed Changes:

Changed the schema of "meta" field in REST API, fileupload endpoint to dict.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mayankjobanputra mayankjobanputra marked this pull request as ready for review March 7, 2023 10:10
@mayankjobanputra mayankjobanputra requested a review from a team as a code owner March 7, 2023 10:10
@mayankjobanputra mayankjobanputra requested review from silvanocerza and removed request for a team and silvanocerza March 7, 2023 10:10
@TuanaCelik
Copy link
Contributor

@manulpatel @mayankjobanputra left a comment for you on Discord so I'm adding it here for records:

Thanks for the PR. I allowed the tests to run and I see a few failures. Whenever you get time, please have a look at the failures by clicking on "Details".

The failure of Linting/pylint, you should be able to fix by running the pre-commit steps described in Contributing.md
Please feel free to discuss your questions here or directly on the PR. I will be monitoring both 🙂

@manulpatel manulpatel closed this Mar 25, 2023
@manulpatel manulpatel deleted the file-upload-meta-schema branch April 24, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API file-upload schema for meta
2 participants