Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add license classifiers #680

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: add license classifiers #680

merged 1 commit into from
Apr 24, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 23, 2024

Fixes #650

  • Once this PR gets merged, the change will be visible after the first release of each package.
  • I propose we don't release the packages only for this reason

@masci masci requested a review from a team as a code owner April 23, 2024 06:42
@masci masci requested review from shadeMe and removed request for a team April 23, 2024 06:42
shadeMe
shadeMe approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor comment.

integrations/amazon_bedrock/pyproject.toml
@@ -14,6 +14,7 @@ authors = [
{ name = "deepset GmbH", email = "[email protected]" },
]
classifiers = [
"License :: OSI Approved :: Apache Software License",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to mention the version (v2.0) here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't be standard, see https://pypi.org/classifiers/

@masci masci merged commit 0f6c388 into main Apr 24, 2024
140 checks passed
@masci masci deleted the massi/license-classifier branch April 24, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock integration:amazon-sagemaker integration:astra integration:chroma integration:cohere integration:deepeval integration:elasticsearch integration:fastembed integration:google-ai integration:google-vertex integration:gradient integration:instructor-embedders integration:jina integration:llama_cpp integration:mistral integration:mongodb-atlas integration:nvidia integration:ollama integration:opensearch integration:optimum integration:pgvector integration:pinecone integration:qdrant integration:ragas integration:unstructured-fileconverter integration:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add license for core integrations on their respective PYPI package website
2 participants
@masci @shadeMe