Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update ragas-haystack docstrings #529

Merged
merged 1 commit into from
Mar 4, 2024
Merged

docs: Update ragas-haystack docstrings #529

merged 1 commit into from
Mar 4, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Mar 4, 2024

@shadeMe shadeMe requested a review from a team as a code owner March 4, 2024 13:46
@shadeMe shadeMe requested review from julian-risch and removed request for a team March 4, 2024 13:46
@github-actions github-actions bot added type:documentation Improvements or additions to documentation integration:ragas and removed type:documentation Improvements or additions to documentation labels Mar 4, 2024
julian-risch
julian-risch approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 The fact that an OPENAI_API_KEY env variable needs to be set is not mentioned in the docstrings anymore but we have it in the documentation page.

@shadeMe shadeMe merged commit 710ac4d into main Mar 4, 2024
10 checks passed
@shadeMe shadeMe deleted the docs/ragas branch March 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
integration:ragas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Docs - integrations.ragas Docstrings - integrations.ragas
2 participants
@shadeMe @julian-risch