Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jina - review docstrings #504

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Jina - review docstrings #504

merged 3 commits into from
Feb 29, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 requested a review from a team as a code owner February 29, 2024 12:01
@anakin87 anakin87 requested review from julian-risch and removed request for a team February 29, 2024 12:01
@github-actions github-actions bot added integration:jina type:documentation Improvements or additions to documentation labels Feb 29, 2024
julian-risch
julian-risch requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of change requests, happy to discuss. :) Let's be consistent throughout the code base.

integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Outdated Show resolved Hide resolved
integrations/jina/src/haystack_integrations/components/embedders/jina/document_embedder.py Show resolved Hide resolved
integrations/jina/src/haystack_integrations/components/embedders/jina/text_embedder.py Outdated Show resolved Hide resolved
integrations/jina/src/haystack_integrations/components/embedders/jina/text_embedder.py Show resolved Hide resolved
julian-risch
julian-risch approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@anakin87 anakin87 merged commit f49523e into main Feb 29, 2024
10 checks passed
@anakin87 anakin87 deleted the jina-docstrings branch February 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
integration:jina type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstrings - integrations.jina
2 participants
@anakin87 @julian-risch