feat: MongoDBAtlas Document Store #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:CI
type:documentation
shadeMe
suggested changes
Feb 15, 2024
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
integrations/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/filters.py
Outdated
Show resolved
Hide resolved
shadeMe
suggested changes
Feb 15, 2024
...ions/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/document_store.py
Outdated
Show resolved
Hide resolved
integrations/mongodb_atlas/src/haystack_integrations/document_stores/mongodb_atlas/filters.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Madeesh Kannan <[email protected]>
…stores/mongodb_atlas/document_store.py Co-authored-by: Madeesh Kannan <[email protected]>
…stores/mongodb_atlas/filters.py
shadeMe
approved these changes
Feb 15, 2024
masci
reviewed
Feb 15, 2024
|
|
||
| [tool.hatch.version] | ||
| source = "vcs" | ||
| tag-pattern = 'integrations\/pgmongodb-atlasvector-v(?P<version>.*)' |
There was a problem hiding this comment.
This was fixed right after the merge: #426
| deserialize_secrets_inplace(data["init_parameters"], keys=["mongo_connection_string"]) | ||
| return default_from_dict(cls, data) | ||
|
|
||
| def count_documents(self, filters: Optional[Dict[str, Any]] = None) -> int: |
There was a problem hiding this comment.
This doesn't respect the protocol: https://github.com/deepset-ai/haystack/blob/main/haystack/document_stores/types/protocol.py#L38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #143
Add support for MongoDB Atlas in the form of
MongoDBAtlasDocumentStore.Note that:
The missing features will be added in later PRs.