Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add application name #1245

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: add application name #1245

merged 2 commits into from
Dec 13, 2024

Conversation

wochinge
Copy link
Contributor

Related Issues

  • fixes #issue-number

Proposed Changes:

  • add application param

How did you test it?

Notes for the reviewer

Checklist

@wochinge wochinge requested a review from a team as a code owner December 12, 2024 16:43
@wochinge wochinge requested review from mpangrazzi and removed request for a team December 12, 2024 16:43
@github-actions github-actions bot added integration:snowflake type:documentation Improvements or additions to documentation labels Dec 12, 2024
@wochinge wochinge force-pushed the chore/add-application-param branch from 72634ca to 3d78f15 Compare December 12, 2024 16:48
@julian-risch julian-risch requested review from julian-risch and removed request for mpangrazzi December 12, 2024 16:56
julian-risch
julian-risch approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 The if not query: branch in the run method could be tested with a unit test as an improvement.

julian-risch
julian-risch requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind

@julian-risch julian-risch merged commit 8a435d9 into main Dec 13, 2024
10 checks passed
@julian-risch julian-risch deleted the chore/add-application-param branch December 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
integration:snowflake type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @julian-risch @medsriha