Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoogleAI - fix the content type of ChatMessage content from function #1241

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Dec 10, 2024

Related Issues

Proposed Changes:

  • fix the content type
  • use text instead of content to access the text

How did you test it?

CI

Notes for the reviewer

  • This is a bug fix but also a breaking change. To make things clearer, I think that we can release a major version
  • In the future, when new ChatMessage + Tool are adopted, we should refactor the tool calling section of this Chat Generator and I'm confident that we can handle it better

Checklist

@github-actions github-actions bot added integration:google-ai type:documentation Improvements or additions to documentation labels Dec 10, 2024
@anakin87 anakin87 changed the title fix Gemini fix: GoogleAI - fix the content type of ChatMessage content Dec 10, 2024
@anakin87 anakin87 changed the title fix: GoogleAI - fix the content type of ChatMessage content fix: GoogleAI - fix the content type of ChatMessage content from function Dec 10, 2024
@anakin87 anakin87 marked this pull request as ready for review December 10, 2024 11:57
@anakin87 anakin87 requested a review from a team as a code owner December 10, 2024 11:57
@anakin87 anakin87 requested review from julian-risch and Amnah199 and removed request for a team and julian-risch December 10, 2024 11:57
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@anakin87 anakin87 merged commit 943f8e5 into main Dec 10, 2024
10 checks passed
@anakin87 anakin87 deleted the google-ai-text-fix branch December 10, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:google-ai type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants