Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logger for index deletion failures in Azure AI #1240

Merged
merged 3 commits into from
Dec 10, 2024
Merged

fix: logger for index deletion failures in Azure AI #1240

merged 3 commits into from
Dec 10, 2024

Conversation

Amnah199
Copy link
Contributor

@Amnah199 Amnah199 commented Dec 9, 2024

Related Issues

During nightly tests, some indexes are not being properly deleted, which eventually causes the allowed index quota to be exceeded.

Proposed Changes:

  • Increase the wait time for index deletion to ensure adequate time for the operation to complete.
  • Fix the logger configuration for tests to capture errors correctly.
  • The immediate goal is to verify if errors related to index deletion can be logged; the broader objective is to debug and understand the root cause of index deletion failures.

How did you test it?

NA

Notes for the reviewer

Checklist

@Amnah199 Amnah199 marked this pull request as ready for review December 10, 2024 12:07
@Amnah199 Amnah199 requested a review from a team as a code owner December 10, 2024 12:07
@Amnah199 Amnah199 requested review from anakin87 and vblagoje and removed request for a team and anakin87 December 10, 2024 12:07
vblagoje
vblagoje approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, perhaps just change info level to warning in one of the log calls.

@Amnah199 Amnah199 merged commit 574316d into main Dec 10, 2024
10 checks passed
@Amnah199 Amnah199 deleted the fix-logging-in-azure-ai branch December 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
integration:azure-ai-search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amnah199 @vblagoje