Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fastembed Ranker - update readme and fix example #1198

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

paulmartrencharpro
Copy link
Contributor

Proposed Changes:

Following #1178, I forgot to change the Readme.md.
So, I added an example for the new code and tested and fixed the others.
Also, I found an issue on the examples/ranker_example.py that I wrote

How did you test it?

I checked the page and each example manually.
Plus, I ran the unit tests and the linter

Checklist

@paulmartrencharpro paulmartrencharpro requested a review from a team as a code owner November 18, 2024 16:07
@paulmartrencharpro paulmartrencharpro requested review from shadeMe and removed request for a team November 18, 2024 16:07
@github-actions github-actions bot added integration:fastembed type:documentation Improvements or additions to documentation labels Nov 18, 2024
@anakin87 anakin87 self-requested a review November 18, 2024 16:09
@anakin87 anakin87 changed the title docs: Fastembed - README.md: add new example with the ranker and fix the old ones & examples/ranker_example.py docs: Fastembed Ranker - update readme and fix example Nov 18, 2024
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!

@anakin87 anakin87 merged commit 180dd3b into deepset-ai:main Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:fastembed type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants