Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio nodes (text2speech, speech2text) #1

Merged
merged 42 commits into from
Oct 21, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Sep 16, 2022

Parallel Haystack PRs - deepset-ai/haystack#3229 deepset-ai/haystack#2676

Due to the (rather fragile) additional deps introduced into Haystack with the addition of Speech nodes, this PR creates the equivalent external nodes, to simplify maintenance of both projects.

Note: after this change, extra nodes will be to be imported by the script loading the YAML pipeline, in order to be found. So for example:

from haystack import Pipeline
from text2speech import AnswerToSpeech

pipe = Pipeline.load_from_yaml("pipeline.haystack-pipeline.yml")

Components ported:

  • Nodes:
    • text2speech: AnswerToSpeech, DocumentToSpeech and relative base classes
    • speech2text: Wav2VecTranscriber, AeneasTranscriptAligner and relative base classes
  • Utility classes
  • Relevant primitives: SpeedDocument and SpeechAnswer (removed)
  • Relative errors: Text2SpeechNodeError, Speech2TextNodeError
  • print_answers --> print_audio_answers (removed)
  • Test for nodes, utilities, primitives, and their samples
  • Tutorial
  • Dependency blocks from pyproject.toml
  • JSON Schemas
  • CI - now each package has their own, namespaced in .github/workflows
  • Pre-commit hooks - now each package has their own
    • These new pre-commit also run mypy and the YAML generation quite quickly!
    • PyLint couldn't be made working
  • mypy, pylint, pytest, black... configurations in pyproject.toml

Open questions:

  • IDE YAML Validation: seems to be working but I want to make more in-depth tests
  • Release process: synced with haystack?

@ZanSara ZanSara changed the title Extract speech nodes from Haystack [text2speech_nodes] Extract speech nodes from Haystack Sep 16, 2022
ZanSara added a commit to deepset-ai/haystack that referenced this pull request Sep 16, 2022
@ZanSara ZanSara marked this pull request as draft September 16, 2022 09:55
@ZanSara ZanSara marked this pull request as ready for review September 19, 2022 13:18
@ZanSara ZanSara changed the title [text2speech_nodes] Extract speech nodes from Haystack Audio nodes (text2speech, speech2text) Oct 21, 2022
@ZanSara ZanSara merged commit f23c590 into deepset-ai:main Oct 21, 2022
masci added a commit that referenced this pull request Nov 9, 2023
chore: update to the new `Document` object
julian-risch added a commit that referenced this pull request Dec 15, 2023
* feat: qdrant-haystack

* ci: Create qdrant.yml

* docs: Update README.md, mypy overrides (#1)

* docs: Update README.md

* chore: mypy overrides

* docs: README.md typo fix

* chore: update pyproject.toml (#2)

* chore: pin pyproject.toml version

* Update pyproject.toml

* Update pyproject.toml

* Delete integrations/qdrant/src/qdrant_haystack/utils.py

* Rename test_dict_convertors.py to test_dict_converters.py

---------

Co-authored-by: Julian Risch <[email protected]>
ElenaKusevska pushed a commit to Anant/haystack-core-integrations that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant