Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cards #119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix cards #119

wants to merge 4 commits into from

Conversation

achikin
Copy link
Member

@achikin achikin commented Jul 3, 2018 •
edited
Loading

  • Speaker's card layout replaced with flex
  • Speaker's cards are no equal height

screen shot 2018-07-03 at 19 54 23

  • Page title is centered on narrow screen

screen shot 2018-07-03 at 19 54 36

  • Встречи преобразованы в лист
    screen shot 2018-07-04 at 14 37 16

trubachev
trubachev reviewed Jul 3, 2018
View reviewed changes
speakers.html
</h5>
</div>
<div class="card speaker-card card-margin">
<a href={{speaker.url}}><img class="card-img-top" src="{{speaker.avatar}}" alt="{{speaker.title}}"/></a>
Copy link
Contributor

@trubachev trubachev Jul 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно всю карточку обернуть в <a>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Согласен.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так слетает автоматическое выравнивание по высоте в карточке.

@aikikode
Copy link
Contributor

aikikode commented Jul 3, 2018

Карточки спикеров хорошо получились, но во встречах теперь тяжело отследить их порядок. Они идут в три колонки каждая снизу вверх по возрастанию - не очень удобно. Может там также зафорсить размер изображения и привести все встречи к одному виду?

@achikin
Copy link
Member Author

achikin commented Jul 4, 2018

@aikikode я бы вообще их списком сделал.

@aikikode
Copy link
Contributor

aikikode commented Jul 4, 2018

@achikin давай зафорсим единый размер для всех картинок встреч - так эта страничка будет выглядеть так же ровно, как и страница спикеров.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trubachev trubachev trubachev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achikin @aikikode @trubachev