Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron 31.7.6 #166

Merged
merged 2 commits into from
Dec 11, 2024
Merged

electron 31.7.6 #166

merged 2 commits into from
Dec 11, 2024

Conversation

Dexus
Copy link
Collaborator

@Dexus Dexus commented Dec 10, 2024

  • updated to electron v31.7.6

@Dexus Dexus mentioned this pull request Dec 10, 2024
main.js Outdated Show resolved Hide resolved
@ShaMan123
Copy link
Contributor

@Dexus I see all your PRs do not conflict with my fork... I can rebase on top of it and then if you wish you/we can PR it into upstream (as long as @abebeos is up for the work)

@Dexus Dexus changed the title electron 33.2.1 + some more fixes electron 33.2.1 Dec 11, 2024
@Dexus
Copy link
Collaborator Author

Dexus commented Dec 11, 2024

Do we have any more C++ living developers on hand?

I'm surprised that it always falls flat on its face here... Only on Windows, but since I don't know C++ I'm stuck here. Theoretically, it should be enough if we don't build the plugin directly here in the project, but provide it as a real plugin. Which we can then import into Electron and also at NodeJ level.

If I'm not completely wrong now, and I'm running 33.2.1 on Windows at least... until the day before yesterday and I restarted the PC... Otherwise we would have to go back to electron v3x. Why is electron doing their own stupid thing again anyway?

  • will first go forward with the other things. I need help here.

@Dexus Dexus changed the title electron 33.2.1 electron 31.7.6 Dec 11, 2024
@Dexus
Copy link
Collaborator Author

Dexus commented Dec 11, 2024

Okay, since electon use a never v8 engine with v32 + v33 then nodejs use, it will not compile. So i moved it back to the v31. Which is working. And a note for myself: don't build electron yourself again O_o this makes things working for you but not in the wild.

@Dexus
Copy link
Collaborator Author

Dexus commented Dec 11, 2024

@ShaMan123 @abebeos if you like to review, I will create the other PRs based on this one.

@Dexus Dexus mentioned this pull request Dec 11, 2024
Copy link
Member

@abebeos abebeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving visually, not tested locally with the packaged app.

@Dexus
Copy link
Collaborator Author

Dexus commented Dec 11, 2024

Will first on Monday again ready have from tomorrow a short vacation

Copy link
Contributor

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can introduce the test file I wrote that executes the app or introduce playwright if it works with v31 on linux (v19 didn't) so we have a baseline...

@abebeos abebeos merged commit 4795327 into deepnest-io:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants