-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron 31.7.6 #166
electron 31.7.6 #166
Conversation
Dexus
commented
Dec 10, 2024
•
edited
Loading
edited
- updated to electron v31.7.6
Do we have any more C++ living developers on hand? I'm surprised that it always falls flat on its face here... Only on Windows, but since I don't know C++ I'm stuck here. Theoretically, it should be enough if we don't build the plugin directly here in the project, but provide it as a real plugin. Which we can then import into Electron and also at NodeJ level. If I'm not completely wrong now, and I'm running 33.2.1 on Windows at least... until the day before yesterday and I restarted the PC... Otherwise we would have to go back to electron v3x. Why is electron doing their own stupid thing again anyway?
|
Okay, since electon use a never v8 engine with v32 + v33 then nodejs use, it will not compile. So i moved it back to the v31. Which is working. And a note for myself: |
@ShaMan123 @abebeos if you like to review, I will create the other PRs based on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving visually, not tested locally with the packaged app.
Will first on Monday again ready have from tomorrow a short vacation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can introduce the test file I wrote that executes the app or introduce playwright if it works with v31 on linux (v19 didn't) so we have a baseline...