ci(): upgrade to electron@19 + add e2e tests

[ShaMan123]

• upgrade to electron@19
  • upgrade nan binding
  • couldn't upgrade to higher versions due to the need for context isolation/bridging that requires a major rewrite
• add e2e tests
  • playwright not working on linux (probably due to old electron version)
  • standalone test on built app is working

[abebeos]

@ShaMan123 , thanks for this. Looks like high-effort to review. Would you be willing to make a separate PR that includes only(!) the minimum changes for an upgrade to electron 19? You should not introduce or alter anything not needed for the upgrade.

[ShaMan123]

I can remove the tests. The rest is needed and is the bare minimum.
I am working now on isolating the logic so it can be used as a node module... the code is not in a good condition.
So I am not sure. Maybe it is best to close this PR and try to make it a node module. Then I can bind the electron app with the latest version as a consumer.

[ShaMan123]

Moving to electron latest will require this anyways

[abebeos]

this

You mean the decoupling to a node_module?

[abebeos]

I can remove the tests. The rest is needed and is the bare minimum.

I would prefer to have the tests in a follow-up PR.

[abebeos]

avoid the use of "ubuntu-latest", future updates can break the build. Better to pin on the versions you know to work.

[ShaMan123]

np

[ShaMan123]

this

You mean the decoupling to a node_module?

yes

[ShaMan123]

I can remove the tests. The rest is needed and is the bare minimum.

I would prefer to have the tests in a follow-up PR.

What do you think in terms of strategy? Shall we go for the node module decoupling or first we merge this PR since it is less disruptive? The decoupling is based on this head anyways.

[abebeos]

What do you think in terms of strategy?

Me dizzy. First day I look again at code after a longer general break. If you feel confident that you can go through with this, then choose the strategy yourself.

Just try to have easy verifiable chunks (PRs). I'll give you access-rights, to fasten things up.

[abebeos]

strategy

• PR update to electron 19
• PR add more tests
• PR(s) node_module stuff for further electron updates, keep it in increments, avoid super-PRs.

[abebeos]

And a general remark: you need to avoid single-commit PRs. Leav the commits for easier review, you can then later squash down the commit-count, sometimes even to one.

[ShaMan123]

Will do. I will close this PR and start a new one.
At some point I suggest introducing prettier and lint for code quality and doing a whitespace PR (very disruptive, non reviewable)

[abebeos]

At some point I suggest introducing prettier and lint for code quality

why not.

You should have gotten some kind of invite here on github.

[ShaMan123]

Got it, thanks.
I am removing electron-settings - seems to cause issues.
Any problems? Should I persist the settings in some app folder?

[ShaMan123]

Or shall I use localStorage? Is that valid with electron? Does it persist after a new version?

[ShaMan123]

closing in favor of #159