Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code comment for InputNlist struct #968

Merged
merged 3 commits into from
Aug 14, 2021

Conversation

denghuilu
Copy link
Member

No description provided.

@denghuilu denghuilu requested a review from njzjz August 13, 2021 07:58
@codecov-commenter
Copy link

Codecov Report

Merging #968 (6914071) into devel (ee0f6e6) will decrease coverage by 11.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            devel     #968       +/-   ##
===========================================
- Coverage   75.37%   64.28%   -11.09%     
===========================================
  Files          85        5       -80     
  Lines        6801       14     -6787     
===========================================
- Hits         5126        9     -5117     
+ Misses       1675        5     -1670     
Impacted Files Coverage Δ
source/lib/include/neighbor_list.h 100.00% <ø> (ø)
deepmd/fit/dipole.py
source/op/_prod_virial_grad.py
deepmd/infer/deep_pot.py
deepmd/fit/polar.py
deepmd/fit/__init__.py
deepmd/infer/deep_polar.py
deepmd/train/trainer.py
deepmd/fit/wfc.py
deepmd/entrypoints/compress.py
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0f6e6...6914071. Read the comment docs.

@njzjz
Copy link
Member

njzjz commented Aug 13, 2021

I forgot to mention.. Use the doxygen style introduced here https://wiki.rdkcentral.com/plugins/servlet/mobile?contentId=20807878#content/view/20807878

@denghuilu
Copy link
Member Author

@njzjz Any suggestion to solve this problem?
image

@denghuilu
Copy link
Member Author

I forgot to mention.. Use the doxygen style introduced here https://wiki.rdkcentral.com/plugins/servlet/mobile?contentId=20807878#content/view/20807878

OK

@njzjz
Copy link
Member

njzjz commented Aug 13, 2021

- name: pip cache
uses: actions/cache@v2
with:
path: ~/.cache/pip
key:
${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}-${{ hashFiles('**/requirements.txt') }}
restore-keys: |
${{ runner.os }}-pip-

Matplotlib has a update today. There should be a wrong cache of pypi index. However, GitHub provides no way to clean the cache.

@njzjz
Copy link
Member

njzjz commented Aug 13, 2021

@amcadmus amcadmus merged commit 6c83c27 into deepmodeling:devel Aug 14, 2021
@njzjz
Copy link
Member

njzjz commented Aug 14, 2021

Finally, someone has the same cache issue: matplotlib/matplotlib#20834 - So I think the cache is on the network side.

gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
* add code comment for InputNlist struct

* use doxygen style for comments

* fix line changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants