-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor docs #952
refactor docs #952
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #952 +/- ##
==========================================
- Coverage 75.51% 75.37% -0.15%
==========================================
Files 85 85
Lines 6796 6801 +5
==========================================
- Hits 5132 5126 -6
- Misses 1664 1675 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The links in the
README.md
at the deepmd-kit source root are broken. - How a user conveniently read the doc locally or from the github website? or we only want to provide the doc through readthedoc?
It's hard to support all of them at the same time. However, I can provide a |
Maybe I can provide a separated catalog for GitHub or Gitee users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change this:
exhale_args = {
...
"rootFileName": "api_cc.rst",
...
}
to
exhale_args = {
...
"rootFileName": "../development/api_cc.rst",
...
}
Then the automatically built api_cc.rst will be in directory doc/development/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, regarding @amcadmus 's comments, you can have both index.rst and index.md in the same directory, RST will go for index.rst automatically.
doc/index.rst
Outdated
:caption: Developer Guide | ||
|
||
development/index | ||
api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you can change here to
.. toctree
:maxdepth: 3
:caption: Developer Guide
:glob:
development/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, sections will be disordered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sections won't change much. Originally, the list was like this
.. toctree::
:maxdepth: 3
:caption: Developer Guide
api
API_CC/api_cc
development/coding-conventions
development/type-embedding
The automatically generated one with ":glob:" is exactly the same.
|
||
.. _trouble: | ||
|
||
.. toctree:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this directory to handle possible changes in the future, may we consider this:
.. toctree::
:maxdepth: 1
:caption: trouble shooting
:glob:
./*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turned out to work out fine.
Co-authored-by: tuoping <[email protected]>
Not work. |
doc/index.rst
Outdated
:caption: Developer Guide | ||
|
||
development/index | ||
development/api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works:
.. toctree::
:maxdepth: 3
:caption: Developer Guide
:glob:
development/*
API_CC/api_cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sections will be ordered like this:
Developer Guide
Python API
Coding Conventions
Atom Type Embedding
C++ API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview here:
https://deepmd-kit.readthedocs.io/en/refactor-docs/
* refactor docs * Update type-embedding.md * fix typos * Update lammps.md * Update model-deviation.md * fix typos * fix links in readme; rewrite training * refactor model part * fix several typos; move sections * Update doc/third-party/lammps-command.md Co-authored-by: tuoping <[email protected]> * create markdown files * revert api_cc * update developer toxtree * remove unexpected api_cc.rst Co-authored-by: Han Wang <[email protected]> Co-authored-by: tuoping <[email protected]>
Since there are lots of parameters still not added (deepmodeling#771, deepmodeling#773, deepmodeling#774, deepmodeling#781, deepmodeling#782), we only enable loose check for `dpgen run` (i.e. `strict_check=False`).
See https://explore-deepmd.njzjz.win/ for preview.
PDF: https://explore-deepmd.njzjz.win/_/downloads/en/latest/pdf/