Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make native MD compatible with v2.0 #950

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 12, 2021

Although no one really enables and uses it, I still make it compatible with v2.0.
Also fix compilation errors.
Seems there is hard-code DOUBLE in the code, and I have no time to fix it, so I comment the build for float precision.

Although no one really enables and uses it, I still make it compatible with v2.0.
Also fix compilation errors.
Seems there is hard-code `DOUBLE` in the code, so I comment the float precision.
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #950 (88eb5c2) into devel (5529a97) will decrease coverage by 7.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #950      +/-   ##
==========================================
- Coverage   83.30%   75.51%   -7.80%     
==========================================
  Files         118       85      -33     
  Lines        9982     6796    -3186     
==========================================
- Hits         8316     5132    -3184     
+ Misses       1666     1664       -2     
Impacted Files Coverage Δ
source/api_cc/tests/test_deepdipole.cc
source/lib/tests/test_prod_force_r.cc
source/lib/tests/test_simulation_region.cc
source/lib/tests/test_prod_force_grad_r.cc
source/api_cc/tests/test_deeppot_model_devi.cc
source/lib/tests/test_soft_min_switch_force.cc
source/lib/tests/test_neighbor_list.cc
source/lib/tests/test_coord.cc
source/lib/tests/test_gelu.cc
source/lib/tests/test_prod_virial_a.cc
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5529a97...88eb5c2. Read the comment docs.

@amcadmus amcadmus merged commit 3c2a2bd into deepmodeling:devel Aug 12, 2021
@njzjz njzjz deleted the native-md branch August 12, 2021 22:19
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
Although no one really enables and uses it, I still make it compatible with v2.0.
Also fix compilation errors.
Seems there is hard-code `DOUBLE` in the code, so I comment the float precision.
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants