throw a message if tf runtime is incompatible #797
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #797 +/- ##
==========================================
- Coverage 74.05% 73.96% -0.09%
==========================================
Files 84 84
Lines 6576 6588 +12
==========================================
+ Hits 4870 4873 +3
- Misses 1706 1715 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This PR checks the compile-time TF version with the run-time TF version, and raise a runtime error if the versions do not match.
However, sometimes in compatible compile-time and run-time TF versions are allowed, do I understand it correctly? If so, we should raise an warning message rather than an error.
There was a problem hiding this comment.
I agree with most of the changes made by this PR, except one thing described below
This PR checks the compile-time TF version with the run-time TF version, and raise a runtime error if the versions do not match.
However, sometimes in compatible compile-time and run-time TF versions are allowed, do I understand it correctly? If so, we should raise an warning message rather than an error.
outdated, please ignore this review |
* throw a message if tf runtime is incompatible fix deepmodeling#557 and deepmodeling#796. * still raise if tf version is correct * detect TF_CXX11_ABI_FLAG * format codes * fix lint * move messages into the function * fix lint * fix lints
fix #406, #447, #557, #774 and #796.