Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for model version #418

Merged
merged 6 commits into from
Mar 16, 2021
Merged

Add support for model version #418

merged 6 commits into from
Mar 16, 2021

Conversation

amcadmus
Copy link
Member

  • Model version in format MODEL_VERSION_MAJOR.MODEL_VERSION_MINOR
  • Implemented in both c++ and python interfaced
  • Disentangle DeepPot from DeepTensor. DeepTensor may become a base class of DeepPot when the model is better designed.
  • Use model_attr/output_dim to determine the output dimension when inferring DeepTensor

@codecov-io
Copy link

codecov-io commented Mar 16, 2021

Codecov Report

Merging #418 (91971a2) into api (3bd863b) will increase coverage by 0.24%.
The diff coverage is 94.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              api     #418      +/-   ##
==========================================
+ Coverage   60.09%   60.34%   +0.24%     
==========================================
  Files          65       66       +1     
  Lines        5157     5202      +45     
==========================================
+ Hits         3099     3139      +40     
- Misses       2058     2063       +5     
Impacted Files Coverage Δ
deepmd/entrypoints/freeze.py 19.56% <ø> (ø)
deepmd/infer/deep_eval.py 96.90% <91.30%> (-1.50%) ⬇️
deepmd/infer/deep_tensor.py 93.10% <93.10%> (ø)
deepmd/infer/deep_dipole.py 75.00% <100.00%> (ø)
deepmd/infer/deep_polar.py 65.21% <100.00%> (ø)
deepmd/infer/deep_pot.py 68.78% <100.00%> (+3.29%) ⬆️
deepmd/infer/deep_wfc.py 58.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd863b...91971a2. Read the comment docs.

@amcadmus
Copy link
Member Author

amcadmus commented Mar 16, 2021

  • Disentangle DeepPot from DeepTensor. DeepTensor may become a base class of DeepPot when the model is better designed.

@marian-code please note the above change

@amcadmus amcadmus merged commit fe1b76c into deepmodeling:api Mar 16, 2021
@marian-code
Copy link
Contributor

  • Disentangle DeepPot from DeepTensor. DeepTensor may become a base class of DeepPot when the model is better designed.

@marian-code please note the above change

Thanks for the heads up! I have been preoccupied with other things so I haven't been able to contribute anything for the last weeks.

gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants