Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass ntypes to sub descriptors in the hybrid descriptor #2611

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 12, 2023

Fix a bug introduced in #2549.

Add tests for it.

Signed-off-by: Jinzhe Zeng <[email protected]>
(cherry picked from commit 0674c54)
@njzjz njzjz marked this pull request as ready for review June 12, 2023 21:59
@njzjz njzjz changed the title pass ntypes to hybrid descriptor pass ntypes to sub descriptors in the hybrid descriptor Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (bb0d02b) 76.66% compared to head (ea0e342) 76.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2611      +/-   ##
==========================================
+ Coverage   76.66%   76.81%   +0.15%     
==========================================
  Files         233      233              
  Lines       24146    24169      +23     
  Branches     1693     1693              
==========================================
+ Hits        18511    18565      +54     
+ Misses       4518     4486      -32     
- Partials     1117     1118       +1     
Impacted Files Coverage Δ
deepmd/descriptor/hybrid.py 59.09% <100.00%> (+33.28%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

njzjz added 2 commits June 12, 2023 18:39
Signed-off-by: Jinzhe Zeng <[email protected]>
Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz mentioned this pull request Jun 12, 2023
61 tasks
@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) June 12, 2023 23:08
@wanghan-iapcm wanghan-iapcm merged commit 18029df into deepmodeling:devel Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants