-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the dependency on inputs
from inputs_zero
#1417
Conversation
When profiling on multiple CPU threads, I notice that `inputs_zero` always runs after descriptor is computed. However, Some threads have nothing to do during ProdEnvMatA. (cherry picked from commit e704b4a)
Codecov Report
@@ Coverage Diff @@
## devel #1417 +/- ##
==========================================
+ Coverage 74.42% 75.71% +1.29%
==========================================
Files 92 92
Lines 7507 7656 +149
==========================================
+ Hits 5587 5797 +210
+ Misses 1920 1859 -61
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a good idea to change the interface of the EnerFitting
for the sake of little performance improvement.
I can add it to |
Done. It will also work when there's nothing in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR, but I really do not like the input_dict
, which makes the interfaces unclear...
When profiling on multiple CPU threads, I notice that
inputs_zero
always runs after descriptor is computed. However, Some threads have nothing to do duringProdEnvMatA
.inputs_zero
can be used to fill waiting time and runs withProdEnvMatA
at the same time...(cherry picked from commit e704b4a)