fix model compression error #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkulzy plz check the rocm implementation, thanks~ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1043 +/- ##
=======================================
Coverage 75.10% 75.10%
=======================================
Files 87 87
Lines 6953 6953
=======================================
Hits 5222 5222
Misses 1731 1731 ☔ View full report in Codecov by Sentry. |
amcadmus
requested changes
Aug 27, 2021
galeselee
approved these changes
Aug 27, 2021
I'll address it. |
amcadmus
approved these changes
Aug 27, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
* fix model compression error * add doc for model compression limitation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the code review process, I found that due to the initial settings of shared memory within the kernel
tabulate_fusion_grad_fifth_order_polynomial, the GPU implementation of model compression would require that the last layer of the embedding net must be less than 128. And there is no error message, which may cause potential risks.This PR should fix this problem. At the same time, an error message has been added. Now the size of the last network in model compression must be less than 1024.