use TF's built-in method to get numpy dtype #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got a way to get the numpy type from a int. Take an example
```py
>>> tf.dtypes.as_dtype(19).as_numpy_dtype
<class 'numpy.float16'>
```
`PRECISION_MAPPING` is not used any more, as it's actually not a public API.
By the way, it also supports `str`
```py
>>> tf.dtypes.as_dtype("float16")
tf.float16
```
Codecov Report
@@ Coverage Diff @@
## devel #1035 +/- ##
===========================================
+ Coverage 64.28% 75.07% +10.78%
===========================================
Files 5 87 +82
Lines 14 6945 +6931
===========================================
+ Hits 9 5214 +5205
- Misses 5 1731 +1726
Continue to review full report at Codecov.
|
amcadmus
approved these changes
Aug 25, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
* use TF's built-in method to get numpy dtype
I got a way to get the numpy type from a int. Take an example
```py
>>> tf.dtypes.as_dtype(19).as_numpy_dtype
<class 'numpy.float16'>
```
`PRECISION_MAPPING` is not used any more, as it's actually not a public API.
By the way, it also supports `str`
```py
>>> tf.dtypes.as_dtype("float16")
tf.float16
```
* sadly only `tf.as_dtype` is supported in TF 1.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a way to get the numpy type from a int. Take an example
PRECISION_MAPPINGis not used any more as the int itself is not a public API, and can be safely removed.By the way, it also supports
str