Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move parameters docstring from constructor method to class itself #1011

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 21, 2021

Otherwise it won't be shown in the document.

Also contains other cleanups.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #1011 (3a9ec1c) into devel (472d7c4) will increase coverage by 7.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1011      +/-   ##
==========================================
+ Coverage   74.59%   82.58%   +7.98%     
==========================================
  Files          86      119      +33     
  Lines        6921    10107    +3186     
==========================================
+ Hits         5163     8347    +3184     
- Misses       1758     1760       +2     
Impacted Files Coverage Δ
deepmd/descriptor/hybrid.py 39.65% <ø> (ø)
deepmd/descriptor/loc_frame.py 97.60% <ø> (ø)
deepmd/descriptor/se_a.py 94.23% <ø> (ø)
deepmd/descriptor/se_a_ebd.py 14.58% <ø> (ø)
deepmd/descriptor/se_a_ef.py 54.83% <ø> (ø)
deepmd/descriptor/se_r.py 92.85% <ø> (ø)
deepmd/descriptor/se_t.py 98.01% <ø> (ø)
deepmd/fit/dipole.py 96.92% <ø> (ø)
deepmd/fit/ener.py 93.65% <ø> (ø)
deepmd/fit/polar.py 48.18% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472d7c4...3a9ec1c. Read the comment docs.

@njzjz njzjz force-pushed the docstrings-constructor branch from 933c507 to f3652e7 Compare August 21, 2021 21:41
Otherwise it won't be shown in the document.

Also contains other cleanups.
@njzjz njzjz force-pushed the docstrings-constructor branch from f3652e7 to 3a9ec1c Compare August 21, 2021 21:42
@njzjz njzjz assigned denghuilu and unassigned denghuilu Aug 21, 2021
@njzjz njzjz requested a review from denghuilu August 21, 2021 21:47
@amcadmus amcadmus merged commit d42ca99 into deepmodeling:devel Aug 22, 2021
@njzjz njzjz deleted the docstrings-constructor branch August 22, 2021 21:12
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
…epmodeling#1011)

Otherwise it won't be shown in the document.

Also contains other cleanups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants