Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in setup.py #1002

Merged
merged 2 commits into from
Aug 21, 2021
Merged

fix a bug in setup.py #1002

merged 2 commits into from
Aug 21, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 20, 2021

I got what's wrong here...

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1002 (ad5e6e8) into devel (f2a7303) will increase coverage by 7.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1002      +/-   ##
==========================================
+ Coverage   75.46%   83.27%   +7.81%     
==========================================
  Files          85      118      +33     
  Lines        6794     9980    +3186     
==========================================
+ Hits         5127     8311    +3184     
- Misses       1667     1669       +2     
Impacted Files Coverage Δ
source/api_cc/tests/test_deeppot_r.cc 100.00% <0.00%> (ø)
source/lib/tests/test_gelu.cc 100.00% <0.00%> (ø)
source/lib/tests/test_prod_force_grad_r.cc 100.00% <0.00%> (ø)
source/api_cc/tests/test_utils.h 97.22% <0.00%> (ø)
source/lib/tests/test_prod_force_a.cc 100.00% <0.00%> (ø)
source/lib/tests/test_ewald.cc 100.00% <0.00%> (ø)
source/lib/tests/test_main.cc 100.00% <0.00%> (ø)
source/lib/tests/test_prod_virial_a.cc 100.00% <0.00%> (ø)
source/lib/tests/test_prod_force_grad_a.cc 100.00% <0.00%> (ø)
source/lib/tests/test_prod_virial_grad_r.cc 100.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a7303...ad5e6e8. Read the comment docs.

@njzjz njzjz requested a review from amcadmus August 20, 2021 20:30
@amcadmus amcadmus merged commit 532e84b into deepmodeling:devel Aug 21, 2021
@njzjz njzjz deleted the setup branch August 22, 2021 03:19
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
* fix a bug in `setup.py`

I got what's wrong here...

* remove `Distribution`
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Remove the old dispatcher and all related tests and examples.
Fix deepmodeling#1002. Close deepmodeling#522.

Signed-off-by: Jinzhe Zeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants