Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect type hints and docstrings #1001

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 20, 2021

For example, Return should be Returns... See style guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #1001 (8ba1352) into devel (f2a7303) will decrease coverage by 11.17%.
The diff coverage is n/a.

❗ Current head 8ba1352 differs from pull request most recent head 9acd269. Consider uploading reports for the commit 9acd269 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            devel    #1001       +/-   ##
===========================================
- Coverage   75.46%   64.28%   -11.18%     
===========================================
  Files          85        5       -80     
  Lines        6794       14     -6780     
===========================================
- Hits         5127        9     -5118     
+ Misses       1667        5     -1662     
Impacted Files Coverage Δ
deepmd/infer/__init__.py
deepmd/__init__.py
source/op/_prod_virial_grad.py
deepmd/descriptor/se_a_ebd.py
deepmd/utils/sess.py
deepmd/entrypoints/config.py
deepmd/infer/deep_wfc.py
deepmd/utils/convert.py
source/op/_soft_min_force_grad.py
source/op/_prod_force_se_a_grad.py
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a7303...9acd269. Read the comment docs.

@amcadmus amcadmus merged commit 16b81f4 into deepmodeling:devel Aug 21, 2021
@njzjz njzjz deleted the docstring branch August 22, 2021 03:18
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
* fix incorrect type hints and docstrings

* fix a typo
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants