Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] rebuild library dependencies #926

Closed
njzjz opened this issue Aug 5, 2021 · 1 comment · Fixed by #930
Closed

[Feature Request] rebuild library dependencies #926

njzjz opened this issue Aug 5, 2021 · 1 comment · Fixed by #930
Assignees
@njzjz
Labels
enhancement

Comments

@njzjz
Copy link
Member

njzjz commented Aug 5, 2021

Summary

The present library dependency is strange.

Detailed Description

Currently the library dependency is as follows (using ldd to see):

image

It's a bit strange. Although it can work, we should make it more logical:

image
@amcadmus
Copy link
Member

amcadmus commented Aug 6, 2021

You are right. Could you please update the CMake files accordingly? Thanks!

@njzjz njzjz self-assigned this Aug 6, 2021
@njzjz njzjz mentioned this issue Aug 6, 2021
Merged
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Aug 6, 2021
@njzjz
clean library and header dependencies
d8b8864 
Fix deepmodeling#926.
@njzjz njzjz linked a pull request Aug 6, 2021 that will close this issue
clean library and header dependencies #930
Merged
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Aug 6, 2021
@njzjz
clean library and header dependencies
791e5a9 
Fix deepmodeling#926.
amcadmus pushed a commit that referenced this issue Aug 10, 2021
@njzjz
clean library and header dependencies (#930)
06d591d 
* clean library and header dependencies

Fix #926.

* fix typo in rocm

* set INSTALL_RPATH for libraries
@njzjz njzjz closed this as completed Aug 10, 2021
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this issue Sep 2, 2021
@njzjz
clean library and header dependencies (deepmodeling#930)
e01e7d7 
* clean library and header dependencies

Fix deepmodeling#926.

* fix typo in rocm

* set INSTALL_RPATH for libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean library and header dependencies njzjz/deepmd-kit
2 participants
@amcadmus @njzjz