Skip to content

Commit

Permalink
fix: unmark eval_pd as abstractmethod
Browse files Browse the repository at this point in the history
Many classes don't have this method and become abstract classes. It looks to me these tests are skipped cilently and don't throw errors.

Signed-off-by: Jinzhe Zeng <[email protected]>
  • Loading branch information
njzjz committed Nov 27, 2024
1 parent 4a45fe5 commit 0fa2c6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/tests/consistent/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ def eval_jax(self, jax_obj: Any) -> Any:
"""
raise NotImplementedError("Not implemented")

@abstractmethod
def eval_pd(self, pd_obj: Any) -> Any:
"""Evaluate the return value of PD.
Expand All @@ -194,6 +193,7 @@ def eval_pd(self, pd_obj: Any) -> Any:
pd_obj : Any
The object of PD
"""
raise NotImplementedError("Not implemented")

def eval_array_api_strict(self, array_api_strict_obj: Any) -> Any:
"""Evaluate the return value of array_api_strict.
Expand Down

0 comments on commit 0fa2c6d

Please sign in to comment.