Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fixes nightly build for onnx 1.17.1 #3021

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners March 5, 2024 21:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.21%. Comparing base (ff3978c) to head (3489d45).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3021      +/-   ##
============================================
- Coverage     72.31%   72.21%   -0.10%     
+ Complexity     7293     7287       -6     
============================================
  Files           722      722              
  Lines         32499    32499              
  Branches       3392     3392              
============================================
- Hits          23501    23470      -31     
- Misses         7379     7412      +33     
+ Partials       1619     1617       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -123,8 +123,9 @@ jobs:
run: |
./gradlew :integration:test "-Dai.djl.default_engine=PyTorch"
./gradlew :integration:clean
./gradlew :integration:test "-Dai.djl.default_engine=OnnxRuntime"
./gradlew :integration:clean
# OnnxRuntime 1.17.1 requires GLIBC 2.27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another OS we can use when testing with ARM?

GH self-hosted runners will have arm64 machines soon, maybe we just wait for that and we can move away from our self hosted arm64 runners and avoid all these GLIBC version issues

@frankfliu frankfliu merged commit 063fb8d into deepjavalibrary:master Mar 5, 2024
5 checks passed
@frankfliu frankfliu deleted the onnx branch March 5, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants