Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes test dependencies from dependency submission #2999

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Feb 19, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@zachgk zachgk requested review from frankfliu and a team as code owners February 19, 2024 22:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fcca33) 72.29% compared to head (046e74a) 72.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2999      +/-   ##
============================================
- Coverage     72.29%   72.28%   -0.02%     
+ Complexity     7292     7290       -2     
============================================
  Files           722      722              
  Lines         32525    32525              
  Branches       3395     3395              
============================================
- Hits          23515    23511       -4     
- Misses         7387     7391       +4     
  Partials       1623     1623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachgk zachgk merged commit e6bd293 into deepjavalibrary:master Feb 19, 2024
5 checks passed
@zachgk zachgk deleted the testDeps branch February 19, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants