Revert "Creates DJL manual engine initialization (#2885)" #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6141c48.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
============================================
+ Coverage 72.08% 72.30% +0.21%
- Complexity 5126 7277 +2151
============================================
Files 473 721 +248
Lines 21970 32465 +10495
Branches 2351 3384 +1033
============================================
+ Hits 15838 23474 +7636
- Misses 4925 7377 +2452
- Partials 1207 1614 +407 ☔ View full report in Codecov by Sentry. |
zachgk
added a commit
to zachgk/djl-serving
that referenced
this pull request
Jan 10, 2024
This updates DJL Serving to follow the engine initialization standards set in deepjavalibrary/djl#2885. First, it updates the PyEngineProvider to follow the EngineProvider conventions. It also updates the DependencyManager, fixing some bugs that inspired deepjavalibrary/djl#2934. The dependency manager before this change would always re-register the engine with a new provider. Beforehand, the engine was fully static and unable to re-initialize, so this would not accidentally re-initialize engines. After this, it would re-initialize engines that did not support it causing errors. Instead, it should only register new engines rather than all providers to avoid these accidental re-initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6141c48.
Description
Brief description of what this PR is about