Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit test TestRequirements, add missing TestRequirements #2120

Merged

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Nov 2, 2022

Description

Two sets of changes in this PR:

  • Remove duplicate usage of TestRequirements.someRequirement() in unit tests and move them to a setUp method.
  • Adds missing TestRequirements on some timeseries unit tests to not run on Arm

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Base: 72.08% // Head: 71.21% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (72988db) compared to base (bb5073f).
Patch coverage: 71.46% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2120      +/-   ##
============================================
- Coverage     72.08%   71.21%   -0.88%     
- Complexity     5126     6269    +1143     
============================================
  Files           473      624     +151     
  Lines         21970    27823    +5853     
  Branches       2351     3000     +649     
============================================
+ Hits          15838    19813    +3975     
- Misses         4925     6549    +1624     
- Partials       1207     1461     +254     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...modality/cv/translator/wrapper/FileTranslator.java 44.44% <ø> (ø)
...y/cv/translator/wrapper/InputStreamTranslator.java 44.44% <ø> (ø)
... and 559 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@siddvenk siddvenk force-pushed the refactor-test-requirements branch from bc630f0 to 72988db Compare November 2, 2022 21:33
@siddvenk siddvenk merged commit 22d6ae5 into deepjavalibrary:master Nov 2, 2022
@siddvenk siddvenk deleted the refactor-test-requirements branch November 2, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants