Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Update M5Forecast dataset and its unittest #2105

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested a review from zachgk as a code owner October 26, 2022 18:07
@codecov-commenter
Copy link

Codecov Report

Base: 72.08% // Head: 70.22% // Decreases project coverage by -1.86% ⚠️

Coverage data is based on head (8ca0b1c) compared to base (bb5073f).
Patch coverage: 71.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2105      +/-   ##
============================================
- Coverage     72.08%   70.22%   -1.87%     
- Complexity     5126     6119     +993     
============================================
  Files           473      612     +139     
  Lines         21970    27173    +5203     
  Branches       2351     2946     +595     
============================================
+ Hits          15838    19081    +3243     
- Misses         4925     6671    +1746     
- Partials       1207     1421     +214     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...modality/cv/translator/wrapper/FileTranslator.java 44.44% <ø> (ø)
...y/cv/translator/wrapper/InputStreamTranslator.java 44.44% <ø> (ø)
... and 535 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Otherwise, LGTM

@@ -0,0 +1,3100 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep this in S3/metadata instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better keep it with the code:

  1. This is tightly coupled with the code.
  2. The s3 location become confusing, it doesn't make sense to keep it in unittest dataset
  3. Users has to copy this file if they want to download dataset from Kaggle

@frankfliu frankfliu merged commit 2a637e4 into deepjavalibrary:master Oct 26, 2022
@frankfliu frankfliu deleted the m5 branch October 26, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants