-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[huggingface] Adds Huggingface ModelZoo #1984
Conversation
Change-Id: Ief99e4b5449c95a75582ded9a9e2549e582387c5
} | ||
Type type = new TypeToken<Map<String, Map<String, Object>>>() {}.getType(); | ||
|
||
Path file = dir.resolve("models.json"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may want a models.json for every DJL release version. Otherwise, we may be suggested new models that are not supported for older versions of DJL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently models.json
is per application, assume the same application will use the same Translator. So we don't really need each file per version. The risk would be some model may require enhancement in current Translator. What we can do is add a requires="0.20.0+"
field, so we can filter out those future models that is not compatible with old Translator
Codecov Report
@@ Coverage Diff @@
## master #1984 +/- ##
============================================
- Coverage 72.08% 69.84% -2.25%
- Complexity 5126 5911 +785
============================================
Files 473 586 +113
Lines 21970 26214 +4244
Branches 2351 2832 +481
============================================
+ Hits 15838 18308 +2470
- Misses 4925 6526 +1601
- Partials 1207 1380 +173
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Change-Id: Ief99e4b5449c95a75582ded9a9e2549e582387c5
Description
Brief description of what this PR is about