Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[huggingface] Adds Huggingface ModelZoo #1984

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: Ief99e4b5449c95a75582ded9a9e2549e582387c5

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: Ief99e4b5449c95a75582ded9a9e2549e582387c5
}
Type type = new TypeToken<Map<String, Map<String, Object>>>() {}.getType();

Path file = dir.resolve("models.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may want a models.json for every DJL release version. Otherwise, we may be suggested new models that are not supported for older versions of DJL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently models.json is per application, assume the same application will use the same Translator. So we don't really need each file per version. The risk would be some model may require enhancement in current Translator. What we can do is add a requires="0.20.0+" field, so we can filter out those future models that is not compatible with old Translator

t
Change-Id: I02d5d89c6d39904aa4de98388f4631ed40fee49c
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #1984 (9a32850) into master (bb5073f) will decrease coverage by 2.24%.
The diff coverage is 68.84%.

@@             Coverage Diff              @@
##             master    #1984      +/-   ##
============================================
- Coverage     72.08%   69.84%   -2.25%     
- Complexity     5126     5911     +785     
============================================
  Files           473      586     +113     
  Lines         21970    26214    +4244     
  Branches       2351     2832     +481     
============================================
+ Hits          15838    18308    +2470     
- Misses         4925     6526    +1601     
- Partials       1207     1380     +173     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
.../cv/translator/InstanceSegmentationTranslator.java 0.00% <0.00%> (-86.59%) ⬇️
...nslator/InstanceSegmentationTranslatorFactory.java 7.14% <0.00%> (-11.04%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
... and 499 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@frankfliu frankfliu merged commit 3a66620 into deepjavalibrary:master Sep 6, 2022
@frankfliu frankfliu deleted the hf branch September 6, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants