Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fixes bug in Criteria #1964

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

frankfliu
Copy link
Contributor

Fixes #1961

Change-Id: Ic3b1ca69ddbfffc030a9f301ca129d4ee7fedd2b

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Fixes deepjavalibrary#1961

Change-Id: Ic3b1ca69ddbfffc030a9f301ca129d4ee7fedd2b
@frankfliu frankfliu requested a review from zachgk as a code owner August 25, 2022 19:29
@codecov-commenter
Copy link

Codecov Report

Merging #1964 (a2500ce) into master (bb5073f) will decrease coverage by 2.02%.
The diff coverage is 67.52%.

@@             Coverage Diff              @@
##             master    #1964      +/-   ##
============================================
- Coverage     72.08%   70.06%   -2.03%     
- Complexity     5126     5814     +688     
============================================
  Files           473      572      +99     
  Lines         21970    25801    +3831     
  Branches       2351     2779     +428     
============================================
+ Hits          15838    18077    +2239     
- Misses         4925     6359    +1434     
- Partials       1207     1365     +158     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 473 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@KexinFeng KexinFeng self-requested a review August 25, 2022 21:51
@KexinFeng KexinFeng merged commit a45dc3b into deepjavalibrary:master Aug 25, 2022
@frankfliu frankfliu deleted the criteria branch August 25, 2022 22:18
patins1 pushed a commit to patins1/djl that referenced this pull request Aug 26, 2022
Fixes deepjavalibrary#1961

Change-Id: Ic3b1ca69ddbfffc030a9f301ca129d4ee7fedd2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criteria.builder() confusing behaviour related to ordering
3 participants