Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onnx] Fixes OrtNDArray double close issue #1809

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

frankfliu
Copy link
Contributor

  1. Fixes ONNX Extensions #1804
  2. Fixes crash caused by double close OrtNDArray
  3. NDArray.get() should use alternativeManager if available
  4. getNDArrayInternal() should fail with alternativeManager is disabled

Change-Id: I37767394f3c68dc8a48ba21ae589dfa81407bdb8

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

1. Fixes deepjavalibrary#1804
2. Fixes crash caused by double close OrtNDArray
3. NDArray.get() should use alternativeManager if available
4. getNDArrayInternal() should fail with alternativeManager is disabled

Change-Id: I37767394f3c68dc8a48ba21ae589dfa81407bdb8
@frankfliu frankfliu requested a review from zachgk as a code owner July 19, 2022 04:09
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #1809 (294838e) into master (bb5073f) will decrease coverage by 2.48%.
The diff coverage is 65.16%.

@@             Coverage Diff              @@
##             master    #1809      +/-   ##
============================================
- Coverage     72.08%   69.60%   -2.49%     
- Complexity     5126     5501     +375     
============================================
  Files           473      524      +51     
  Lines         21970    24341    +2371     
  Branches       2351     2654     +303     
============================================
+ Hits          15838    16942    +1104     
- Misses         4925     6085    +1160     
- Partials       1207     1314     +107     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 416 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13453b4...294838e. Read the comment docs.

@frankfliu frankfliu merged commit 05ea413 into deepjavalibrary:master Jul 19, 2022
@frankfliu frankfliu deleted the ort branch July 19, 2022 18:45
KexinFeng pushed a commit to KexinFeng/djl that referenced this pull request Jul 22, 2022
1. Fixes deepjavalibrary#1804
2. Fixes crash caused by double close OrtNDArray
3. NDArray.get() should use alternativeManager if available
4. getNDArrayInternal() should fail with alternativeManager is disabled

Change-Id: I37767394f3c68dc8a48ba21ae589dfa81407bdb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ONNX Extensions
4 participants