Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fix 1773 and 1774 #1789

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Conversation

KexinFeng
Copy link
Contributor

@KexinFeng KexinFeng commented Jul 11, 2022

  1. Fix issue 1773 and issue 1774

In NDArray.set(NDArray index, Number value) add the feature of setting array values with integer indices, as shown in the use case #1773 as well as #1774.

This is similar to pr#1755 and is based on the advanced indexing pr#1719.

  1. Fix an issue in the document of built-from-source

@KexinFeng KexinFeng requested a review from lanking520 July 11, 2022 19:48
docs/get.md Outdated Show resolved Hide resolved
Co-authored-by: Zach Kimberg <[email protected]>
docs/get.md Outdated Show resolved Hide resolved
docs/get.md Show resolved Hide resolved
Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a better commit message to describe this PR is for?

KexinFeng and others added 2 commits July 11, 2022 18:22
@KexinFeng KexinFeng changed the title issue_fix_1773 Issue fix 1773 Jul 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #1789 (7f3b6d3) into master (bb5073f) will decrease coverage by 2.51%.
The diff coverage is 65.10%.

❗ Current head 7f3b6d3 differs from pull request most recent head 2a51665. Consider uploading reports for the commit 2a51665 to get more accurate results

@@             Coverage Diff              @@
##             master    #1789      +/-   ##
============================================
- Coverage     72.08%   69.57%   -2.52%     
- Complexity     5126     5488     +362     
============================================
  Files           473      524      +51     
  Lines         21970    24316    +2346     
  Branches       2351     2644     +293     
============================================
+ Hits          15838    16918    +1080     
- Misses         4925     6086    +1161     
- Partials       1207     1312     +105     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
.../cv/translator/StyleTransferTranslatorFactory.java 40.00% <ø> (ø)
... and 414 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c0eb7...2a51665. Read the comment docs.

@KexinFeng KexinFeng requested review from frankfliu and zachgk July 12, 2022 06:07
@KexinFeng KexinFeng changed the title Issue fix 1773 Issue fix 1773 and 1774 Jul 12, 2022
@KexinFeng KexinFeng merged commit cea6f94 into deepjavalibrary:master Jul 13, 2022
@KexinFeng KexinFeng deleted the issue_fix_1773 branch August 25, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NDArray.set(NDArray index, Number value) failing with int64 index array on gpu
5 participants