-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue fix 1773 and 1774 #1789
Issue fix 1773 and 1774 #1789
Conversation
Co-authored-by: Zach Kimberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a better commit message to describe this PR is for?
Co-authored-by: Frank Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
============================================
- Coverage 72.08% 69.57% -2.52%
- Complexity 5126 5488 +362
============================================
Files 473 524 +51
Lines 21970 24316 +2346
Branches 2351 2644 +293
============================================
+ Hits 15838 16918 +1080
- Misses 4925 6086 +1161
- Partials 1207 1312 +105
Continue to review full report at Codecov.
|
7f3b6d3
to
2a51665
Compare
In
NDArray.set(NDArray index, Number value)
add the feature of setting array values with integer indices, as shown in the use case #1773 as well as #1774.This is similar to pr#1755 and is based on the advanced indexing pr#1719.