[api] Fixes NDArrayAdapter toDevice() and toType() behavior (#1839)

Change-Id: Iaf90c609a832f3f7bc2a863bdb44cfc7df34dbae
deepjavalibrary · Jul 26, 2022 · 2763699 · 2763699
1 parent c04c9ab
commit 2763699
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/api/src/main/java/ai/djl/ndarray/NDArrayAdapter.java b/api/src/main/java/ai/djl/ndarray/NDArrayAdapter.java
@@ -133,19 +133,26 @@ public Shape getShape() {
     /** {@inheritDoc} */
     @Override
     public NDArray toDevice(Device device, boolean copy) {
-        if (device.equals(getDevice()) && !copy) {
+        if (device.equals(getDevice())) {
+            if (copy) {
+                return duplicate();
+            }
             return this;
         }
-        return duplicate();
+        throw new UnsupportedOperationException(UNSUPPORTED_MSG);
     }
 
     /** {@inheritDoc} */
     @Override
     public NDArray toType(DataType dataType, boolean copy) {
-        if (dataType.equals(getDataType()) && !copy) {
+        if (dataType.equals(getDataType())) {
+            if (copy) {
+                return duplicate();
+            }
             return this;
         }
-        return duplicate();
+        // TODO: each engine should override this method
+        throw new UnsupportedOperationException(UNSUPPORTED_MSG);
     }
 
     /** {@inheritDoc} */